fix: add URL validation in common.py... - #3058
Open
anupamme wants to merge 1 commit into
Open
Conversation
Data from request object is passed to a new server-side request Addresses python.django.security.injection.ssrf.ssrf-injection-urllib.ssrf-injection-urllib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Address high severity security finding in
src/you_get/common.py.Vulnerability
python.django.security.injection.ssrf.ssrf-injection-urllib.ssrf-injection-urllibsrc/you_get/common.py:384Description: Data from request object is passed to a new server-side request. This could lead to a server-side request forgery (SSRF), which could result in attackers gaining access to private organization data. To mitigate, ensure that schemes and hosts are validated against an allowlist, do not forward the response to the user, and ensure proper authentication and transport-layer security in the proxied request.
Evidence
Scanner confirmation: semgrep rule
python.django.security.injection.ssrf.ssrf-injection-urllib.ssrf-injection-urllibmatched this pattern as python.django.security.injection.ssrf.ssrf-injection-urllib.ssrf-injection-urllib.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This is a Python library - vulnerabilities affect applications that import this code.
Changes
src/you_get/common.pyVerification
This change addresses a pattern flagged by static analysis. The code path handles user-influenced input and the fix reduces the attack surface against both manual and automated exploitation.
Automated security fix by OrbisAI Security
This change is