Skip to content

Handle template loaders that don't implement get_template_sources #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2018

Conversation

heindsight
Copy link
Collaborator

The django-dbtemplates template loader still uses the django-1.8
load_template_source instead of the newer get_template_sources. This
change allows using django-compress and django-dbtemplates on the same
project.

The django-dbtemplates template loader still uses the django-1.8
`load_template_source` instead of the newer `get_template_sources`. This
change allows using django-compress and django-dbtemplates on the same
project.
@tomviner
Copy link

tomviner commented Jan 22, 2018

+1 looks good to me. NotImplementedError is semantically exactly what this except clause is looking to catch.

@heindsight heindsight merged commit 7c6f2c7 into master Jan 22, 2018
@heindsight heindsight deleted the handle-notimplemented branch January 22, 2018 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants