Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip serializing course tags if None #186

Merged
merged 2 commits into from
Jan 29, 2023
Merged

Skip serializing course tags if None #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c27fbad
update
liadaram1 Jan 28, 2023
83f61ea
Fix full compute flow tests
benny-n Jan 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/server/src/core/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,15 @@ async fn run_degree_status(mut degree_status: DegreeStatus, catalog: Catalog) ->
.get_all::<Course>()
.await
.expect("failed to get all courses");
degree_status
.course_statuses
.iter_mut()
.for_each(|course_status| {
course_status.course.tags = vec_courses
.iter()
.find(|course| course.id == course_status.course.id)
.and_then(|course| course.tags.clone());
});
degree_status.compute(catalog, course::vec_to_map(vec_courses));
degree_status
}
Expand Down
1 change: 1 addition & 0 deletions packages/server/src/resources/course.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ pub struct Course {
pub id: CourseId,
pub credit: f32,
pub name: String,
#[serde(skip_serializing_if = "Option::is_none")]
pub tags: Option<Vec<Tag>>, // All tags for the course, for example "english" and "malag"
}

Expand Down