Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in progress computation #125

Merged
merged 19 commits into from
Apr 1, 2022
Merged

Add in progress computation #125

merged 19 commits into from
Apr 1, 2022

Conversation

liadaram1
Copy link
Collaborator

Create a full flow to compute degree status with regard to courses in progress.

  • add "settings" to User resource
  • add compute_in_progress flag as a setting
  • create PUT /student/settings
  • before degree-status compute, check compute_in_progress flag and change courses statuses if needed.
  • add toggle button UI to client
  • change default course_status from 'complete' to 'in-progress'

@benny-n benny-n added 📁 client App: Client 📁 server App: Server 💡 feature Type: Feature labels Mar 28, 2022
@benny-n benny-n linked an issue Mar 28, 2022 that may be closed by this pull request
Support "in progress" courses #89
Closed
8 tasks
@benny-n
improve ui/ux for compute_in_progress feature
bb21cfe 
 - refactor progress bar to hold 2 colors (one for only complete courses and complete+in progress courses)
 - change `Chip`s to be 'in-progress` when needed
NissanOhana
NissanOhana requested changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@NissanOhana NissanOhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to make a different color theme if the user clicks the toggle? @liadaram1 @benny-n @liadaram1

@benny-n
Copy link
Collaborator

benny-n commented Apr 1, 2022

Do we want to make a different color theme if the user clicks the toggle? @liadaram1 @benny-n @liadaram1

@NissanOhana not sure all of the color theme should change, but we do get a nice progress bar with 3 colors (complete, in-progress, not complete) when the user clicks the toggle

@NissanOhana
Copy link
Collaborator

Do we want to make a different color theme if the user clicks the toggle? @liadaram1 @benny-n @liadaram1

@NissanOhana not sure all of the color theme should change, but we do get a nice progress bar with 3 colors (complete, in-progress, not complete) when the user clicks the toggle

If so, yalla.

NissanOhana
NissanOhana approved these changes Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@NissanOhana NissanOhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.
all the remaining issues (spaghetti code in some component) are because of me 🤤

@liadaram1 - if you checked all cases in the UI - we can merge :)

@NissanOhana
Copy link
Collaborator

IMO we can merge.
@benny-n - want to PR new version stuff (bump version, version modal, etc...) 🕺

@liadaram1 liadaram1 merged commit 5acc94a into development Apr 1, 2022
@liadaram1 liadaram1 deleted the add-in-progress-computation branch April 1, 2022 15:42
@benny-n benny-n mentioned this pull request Apr 2, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NissanOhana NissanOhana NissanOhana approved these changes

@benny-n benny-n benny-n approved these changes

Assignees
No one assigned
Labels
💡 feature Type: Feature 📁 client App: Client 📁 server App: Server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support "in progress" courses
3 participants
@liadaram1 @benny-n @NissanOhana