Refactor nullability handling in RQL properties #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor namespaces and enhance code structure Key changes include: - Enhanced organization of the `RqlExpression` class with method regions for better readability. - Updated `RqlOperators` and `RqlSelectModes` enums to include the `[Flags]` attribute for improved usability. - Refactored `RqlPropertyAttribute` for streamlined handling of actions, operators, and selection modes. - Introduced interfaces like `IRqlNode` and `IRqlQueryable` to promote better object-oriented design. - Restructured `RqlSettings` and related classes for cohesive configuration management. - Updated test files to ensure relevance and functionality with the new structure. These changes aim to improve modularity, readability, and maintainability while adhering to modern C# practices. * namespace adjustments * IRqlMapAccessor moved to abstractions * Refactor RQL configuration and result handling
Replaced manual nullability annotations with automatic detection: - Marked `IsNullable` in `RqlPropertyAttribute` as obsolete. - Added `IsNullable` method in `MetadataFactory` for runtime nullability checks. - Updated `MetadataFactory` to use automatic nullability detection. Added comprehensive tests: - Verified nullability detection for value and reference types. - Ensured correct operator handling based on nullability. - Validated that obsolete `IsNullable` does not interfere. These changes improve maintainability and ensure nullability is determined dynamically.
vgrebenschikov
force-pushed
the
master
branch
from
03606dc to
63916a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced manual nullability annotations with automatic detection:
IsNullableinRqlPropertyAttributeas obsolete.IsNullablemethod inMetadataFactoryfor runtime nullability checks.MetadataFactoryto use automatic nullability detection.Added comprehensive tests:
IsNullabledoes not interfere.These changes improve maintainability and ensure nullability is determined dynamically.