Skip to content

Conversation

@robcsegal
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Oct 2, 2025

Warnings
⚠️

This PR contains 1 merge commit(s).
Please use git pull --rebase to keep a clean, linear history.

Offending commits:

✅ Found Jira issue key in the title: MPT-14081

Generated by 🚫 dangerJS against 053e6fb

@robcsegal robcsegal marked this pull request as draft October 2, 2025 14:36
@robcsegal robcsegal force-pushed the MPT-14081-add-accounts-users-endpoints branch from c42e906 to b4ec06f Compare October 2, 2025 14:39
@robcsegal robcsegal marked this pull request as ready for review October 2, 2025 14:41
)


class BlockableMixin[Model]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to have mixins here if it is used in only 1 resource?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block and unblock is used in ERP links, too. But SSO is not. I thought I saw it in another accounts entity, but it's not.

Does it make sense to have mixins here if it is used in only 1 resource?

@robcsegal robcsegal force-pushed the MPT-14081-add-accounts-users-endpoints branch 2 times, most recently from 6775309 to 5a8d14e Compare October 2, 2025 15:45
@robcsegal robcsegal force-pushed the MPT-14081-add-accounts-users-endpoints branch from 5a8d14e to 053e6fb Compare October 2, 2025 15:47
@robcsegal robcsegal closed this Oct 2, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 2, 2025

@robcsegal robcsegal deleted the MPT-14081-add-accounts-users-endpoints branch October 2, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants