MPT-12326 Updated generic resource and tests #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertsola
requested review from
d3rky,
jentyk,
ruben-sebrango and
svazquezco
as code owners
svazquezco
reviewed
Aug 5, 2025
svazquezco
reviewed
Aug 5, 2025
Comment on lines
42
to
48
| resource.id = 2 | ||
| assert resource.id == 2 | ||
|
|
||
| def test_malformed_meta_response(self): | ||
| with pytest.raises(TypeError, match=re.escape("Response $meta must be a dict.")): | ||
| _resource = GenericResource.from_response(Response(200, json={"data": {}, "$meta": 4})) | ||
| resource.name.given = "John" | ||
| assert resource.name.given == "John" |
Contributor
There was a problem hiding this comment.
We are following AAA which means each section should be grouped together. Sorry, I can't suggest the change directly here.
resource.id = 2
resource.name.given = "John"
assert resource.id == 2
assert resource.name.given == "John"
svazquezco
reviewed
Aug 5, 2025
svazquezco
approved these changes
Aug 5, 2025
d3rky
approved these changes
Aug 5, 2025
albertsola
commented
Aug 5, 2025
Contributor
Author
albertsola
left a comment
albertsola
left a comment
There was a problem hiding this comment.
Remove extra spaces
albertsola
force-pushed
the
asola/MPT-12327/Collection-result
branch
from
0d63678 to
34659a9
Compare
albertsola
force-pushed
the
asola/MPT-12327/Collection-result
branch
from
34659a9 to
f53b291
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.