MPT-12840 Endpoint commerce agreements attachments #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertsola
changed the title
albertsola
force-pushed
the
MPT-12840/agreements-assets
branch
3 times, most recently
from
0c44c49 to
51555c1
Compare
albertsola
changed the title
albertsola
force-pushed
the
MPT-12840/agreements-assets
branch
3 times, most recently
from
3483671 to
d86f918
Compare
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
albertsola
force-pushed
the
MPT-12840/agreements-assets
branch
from
d86f918 to
2c3600c
Compare
|
d3rky
approved these changes
Sep 5, 2025
svazquezco
reviewed
Sep 5, 2025
|
|
||
| def build_url( | ||
| self, | ||
| query_params: dict[str, Any] | None = None, |
Contributor
There was a problem hiding this comment.
You can remove the comma to avoid splitting the code
svazquezco
reviewed
Sep 5, 2025
Comment on lines
+10
to
+13
| def _json_to_file_payload(resource_data: ResourceData) -> bytes: | ||
| return json.dumps( | ||
| resource_data, ensure_ascii=False, separators=(",", ":"), allow_nan=False | ||
| ).encode("utf-8") |
Contributor
There was a problem hiding this comment.
As we've already discussed, at some point it would be good to move this
svazquezco
reviewed
Sep 5, 2025
Comment on lines
+65
to
+69
| files["_attachment_data"] = ( | ||
| None, | ||
| _json_to_file_payload(resource_data), | ||
| "application/json", | ||
| ) |
Contributor
There was a problem hiding this comment.
Umm… I believe we can also remove the comma to avoid splitting the code unnecessarily
svazquezco
reviewed
Sep 5, 2025
| files["_attachment_data"] = ( | ||
| None, | ||
| _json_to_file_payload(resource_data), | ||
| "application/json", |
svazquezco
reviewed
Sep 5, 2025
Comment on lines
+69
to
+70
| service = AgreementsService(http_client=http_client) | ||
| assert hasattr(service, method) |
Contributor
There was a problem hiding this comment.
Suggested change
| service = AgreementsService(http_client=http_client) | |
| assert hasattr(service, method) | |
| service = AgreementsService(http_client=http_client) | |
| assert hasattr(service, method) |
svazquezco
reviewed
Sep 5, 2025
Comment on lines
+75
to
+76
| service = AgreementsService(http_client=async_http_client) | ||
| assert hasattr(service, method) |
Contributor
There was a problem hiding this comment.
Suggested change
| service = AgreementsService(http_client=async_http_client) | |
| assert hasattr(service, method) | |
| service = AgreementsService(http_client=async_http_client) | |
| assert hasattr(service, method) |
svazquezco
approved these changes
Sep 5, 2025
Contributor
svazquezco
left a comment
svazquezco
left a comment
There was a problem hiding this comment.
Apologies, I didn't do a deep review (holidays are coming 🌴 ) but it looks really good. Just a few boring comments....
d3rky
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.