Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] http4s - migrate from Blaze to Ember #4185

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Less strict check when close frame is not decoded
  • Loading branch information
ivan-klass committed Feb 3, 2025
commit 99af5d3c3e1721df2f01cecc36728064d4c0282d
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ abstract class ServerWebSocketTests[F[_], S <: Streams[S], OPTIONS, ROUTE](
.map(_.last)
.value
.asInstanceOf[Option[Either[WebSocketFrame, String]]]
.forall(_ == Left(WebSocketFrame.Close(1000, "normal closure")))
.forall {
case Left(WebSocketFrame.Close(1000, "normal closure")) if decodeCloseRequests => true
case Left(WebSocketFrame.Close(1000, "" | "normal closure")) if !decodeCloseRequests => true
case _ => false
}
)
}
},
Expand Down
Loading