-
Notifications
You must be signed in to change notification settings - Fork 462
Move Id alias to core. Add serverLogicSync & other variants to Endpoint. #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kciesielski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat. I noticed that the monad is called Id in tapir and Identity in sttp. Maybe we can use this opportunity and call it Identity in Tapir as well? Id is sometimes consfusing (it's often used as type name for "identifier").
Good point. It is a bit long, but I think |
|
@kciesielski While implementing this I got some clashes with sttp3's |
|
Sounds good! |
|
Just a note that the doc at https://tapir.softwaremill.com/en/latest/server/nima.html needs to be updated to reflect this change: +import sttp.shared.Identity
+import sttp.tapir.server.nima.NimaServerInterpreter
-import sttp.tapir.server.nima.{Id, NimaServerInterpreter} |
|
Thanks, fixed! 263cdba |
No description provided.