Skip to content

Conversation

@adamw
Copy link
Member

@adamw adamw commented May 27, 2024

No description provided.

@adamw adamw requested a review from kciesielski May 27, 2024 10:26
Copy link
Member

@kciesielski kciesielski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. I noticed that the monad is called Id in tapir and Identity in sttp. Maybe we can use this opportunity and call it Identity in Tapir as well? Id is sometimes consfusing (it's often used as type name for "identifier").

@adamw
Copy link
Member Author

adamw commented May 27, 2024

Neat. I noticed that the monad is called Id in tapir and Identity in sttp. Maybe we can use this opportunity and call it Identity in Tapir as well? Id is sometimes consfusing (it's often used as type name for "identifier").

Good point. It is a bit long, but I think Id might cause name clashes.

@adamw
Copy link
Member Author

adamw commented May 27, 2024

@kciesielski While implementing this I got some clashes with sttp3's Identity. Hence maybe this should be in sttp-shared simply? We could then use it both in sttp4 & tapir. See: softwaremill/sttp-shared#404

@kciesielski
Copy link
Member

Sounds good!

@adamw adamw merged commit ed7b60e into master May 28, 2024
@adamw adamw deleted the sync-server-logic branch May 28, 2024 07:42
@hohonuuli
Copy link
Contributor

Just a note that the doc at https://tapir.softwaremill.com/en/latest/server/nima.html needs to be updated to reflect this change:

+import sttp.shared.Identity
+import sttp.tapir.server.nima.NimaServerInterpreter
-import sttp.tapir.server.nima.{Id, NimaServerInterpreter}

@adamw
Copy link
Member Author

adamw commented May 29, 2024

Thanks, fixed! 263cdba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants