Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VP8 encoder and VP8 RTP output #1040

Merged
merged 6 commits into from
Apr 8, 2025

Conversation

wkazmierczak
Copy link
Collaborator

No description provided.

@wkazmierczak wkazmierczak marked this pull request as ready for review March 31, 2025 15:43
@wkazmierczak wkazmierczak requested a review from wkozyra95 March 31, 2025 15:43
@wkazmierczak wkazmierczak linked an issue Apr 1, 2025 that may be closed by this pull request
Copy link
Member

@wkozyra95 wkozyra95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend opening PR to docs (next branch) and start updating docs. Not necessarily what already landed, but potentially how the end result will look (up to you)

@@ -94,8 +94,23 @@ fn client_code() -> Result<()> {
}),
)?;

std::thread::sleep(Duration::from_millis(500));
start_gst_receive_tcp(IP, OUTPUT_PORT, true, true)?;
//TODO only temporary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge other PR and replace before merging this

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be cover in next PR #1046

@wkazmierczak wkazmierczak self-assigned this Apr 2, 2025
@wkazmierczak wkazmierczak merged commit 685adb7 into master Apr 8, 2025
4 checks passed
@wkazmierczak wkazmierczak deleted the @wkazmierczak/add-vp8-encoder-rtp-output branch April 8, 2025 10:19
@wkazmierczak wkazmierczak mentioned this pull request Apr 8, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add VP8 encoder and VP8 RTP output
2 participants