Fix web renderer crashing when multiple Smelter instances are run #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add to changelog |
noituri
force-pushed
the
@noituri/cef-handle-new-tab
branch
from
b9ad6a7 to
fa4bda3
Compare
wkozyra95
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When two instances of smelter share the same CEF
root_cache_path, one instance becomes the main browser window, and the other acts as an opened "tab" in that browser. We don't handle that case at all, hence the crash. Fixed it by giving each instance a uniqueroot_cache_pathso now each instance works independently.Fixes: #1014