Mark code blocks as Cairo not Rust #2142
Open
+90
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Mar 31, 2025
maciektr
force-pushed
the
maciektr/doc-patch-highlighter
branch
from
75094eb to
587b7d8
Compare
maciektr
force-pushed
the
maciektr/doc-with-cairo
branch
from
1fd5273 to
916f428
Compare
maciektr
force-pushed
the
maciektr/doc-patch-highlighter
branch
from
587b7d8 to
4206bee
Compare
maciektr
force-pushed
the
maciektr/doc-with-cairo
branch
from
916f428 to
340395b
Compare
FroyaTheHen
reviewed
Apr 8, 2025
| .arg("--output") | ||
| .arg(build_output_dir.clone()) | ||
| .env("SCARB_UI_VERBOSITY", ui.verbosity().to_string()) | ||
| .run()?; |
There was a problem hiding this comment.
did you run it without issues in your local env? I am trying to do that. Yet, command exits with error: no such command: mdbook. However, scarb-metadata/src/command/scarb_command.rs cmd.status() is Ok(ExitStatus(unix_wait_status(256))) so if i change the line if cmd.status()?.success() { to if cmd.status().is_ok() { it builds the book as expected. Any idea what could be wrong with my local env or if is it not env specific?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark code blocks as Cairo not Rust
Add option to build straight from scarb-doc