Remove confusing default from token stream types #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

maciektr merged 1 commit into dev from spr/dev/e6e81399

Nov 26, 2024

Contributor

maciektr commented Nov 14, 2024 •

edited

Loading

commit-id:e6e81399

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Nov 14, 2024

Make TextSpan u32 to match the compiler one #1746

Closed

Allocate token's content into an arena #1722

Merged

Add token stream ser/de tests #1734

Closed

maciektr marked this pull request as ready for review

November 14, 2024 16:27

maciektr requested review from Draggu and a team as code owners

November 14, 2024 16:27

This was referenced Nov 14, 2024

Refactor: split proc macro host into submodules #1747

Merged

Make TextSpan u32 to match the compiler one #1748

Merged

Pass call site to macro expansion #1749

Merged

maciektr force-pushed the spr/dev/e6e81399 branch from fedca96 to 715058c Compare

November 15, 2024 10:34

maciektr force-pushed the spr/dev/65fef41c branch from 56c0dac to cbab9c7 Compare

November 15, 2024 10:34

maciektr changed the base branch from spr/dev/65fef41c to dev

November 15, 2024 10:36

maciektr changed the base branch from dev to spr/dev/6d8f33f9

November 15, 2024 10:36

maciektr force-pushed the spr/dev/e6e81399 branch from 715058c to cd3ef34 Compare

November 15, 2024 10:36

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

4cf13ee

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr force-pushed the spr/dev/e6e81399 branch from cd3ef34 to de6ecb6 Compare

November 15, 2024 10:40

maciektr force-pushed the spr/dev/6d8f33f9 branch from d0d2828 to 2beed13 Compare

November 15, 2024 10:40

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

8b8b19d

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

wawel37 pushed a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

75b0526

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr changed the base branch from spr/dev/6d8f33f9 to dev

November 21, 2024 12:12

maciektr force-pushed the spr/dev/e6e81399 branch from de6ecb6 to e687bf8 Compare

November 21, 2024 12:13

maciektr mentioned this pull request

Implement Debug for InternedStr #1760

Merged

maciektr changed the base branch from dev to spr/dev/6d8f33f9

November 21, 2024 12:13

DelevoXDG reviewed

View reviewed changes

scarb/tests/proc_macro_server.rs Show resolved Hide resolved

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

6cb1d27

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr force-pushed the spr/dev/e6e81399 branch from e687bf8 to 7517e37 Compare

November 21, 2024 16:54

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

17e15c2

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

Base automatically changed from spr/dev/6d8f33f9 to dev

November 21, 2024 16:54

maciektr force-pushed the spr/dev/e6e81399 branch 2 times, most recently from 9ebff73 to 9500690 Compare

November 21, 2024 21:04

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

5fae72d

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

ba87422

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

750ae15

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Skip whitespace prefix when creating the span (#1761)

2af0ac0

commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Remove confusing default from token stream types (#1745)

633e21f

commit-id:e6e81399

---

**Stack**:
- #1749
- #1748
- #1745 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

bac5b8f

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

3a47bfd

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

aa9da7d

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Skip whitespace prefix when creating the span (#1761)

802a3cd

commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Remove confusing default from token stream types (#1745)

6a23870

commit-id:e6e81399

---

**Stack**:
- #1749
- #1748
- #1745 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

d28a731

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

351b170

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Skip whitespace prefix when creating the span (#1761)

6c2b5e8

commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Remove confusing default from token stream types (#1745)

commit-id:e6e81399

---

**Stack**:
- #1749
- #1748
- #1745 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

9c97322

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

9b318d2

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

343755d

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Skip whitespace prefix when creating the span (#1761)

b0ff4aa

commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Remove confusing default from token stream types (#1745)

c58826d

commit-id:e6e81399

---

**Stack**:
- #1749
- #1748
- #1745 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

6b5f595

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

95cc206

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

0c0249e

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Skip whitespace prefix when creating the span (#1761)

36ad79b

commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Remove confusing default from token stream types (#1745)

cf2f0ba

commit-id:e6e81399

---

**Stack**:
- #1749
- #1748
- #1745 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Allocate token's content into an arena (#1722)

5f8a238

commit-id:5e4b122f

Add token stream ser/de tests

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1722 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Implement Debug for InternedStr (#1760)

d86bfa5

commit-id:919c7f28

---

**Stack**:
- #1749
- #1748
- #1745
- #1747
- #1760 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Refactor: split proc macro host into submodules (#1747)

319e70c

commit-id:6d8f33f9

---

**Stack**:
- #1749
- #1748
- #1745
- #1747 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Skip whitespace prefix when creating the span (#1761)

fb7c61d

commit-id:f0ce5a05

---

**Stack**:
- #1749
- #1748
- #1745
- #1761 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

maciektr added a commit that referenced this pull request


          Remove confusing default from token stream types (#1745)

c450e54

commit-id:e6e81399

---

**Stack**:
- #1749
- #1748
- #1745 ⬅

⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet