-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: Respect RN view layout and transforms within ForeignObject #2811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kacperzolkiewski
merged 9 commits into
software-mansion:main
from
kacperzolkiewski:fixForeignObject
Nov 12, 2025
Merged
fix: Respect RN view layout and transforms within ForeignObject #2811
kacperzolkiewski
merged 9 commits into
software-mansion:main
from
kacperzolkiewski:fixForeignObject
Nov 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakex7
reviewed
Nov 12, 2025
Co-authored-by: Jakub Grzywacz <jaqbgrzy@gmail.com>
jakex7
reviewed
Nov 12, 2025
jakex7
reviewed
Nov 12, 2025
jakex7
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2733 (
Bug1,Bug3)Fixes: #1428
Fixes: #2519
Problem
When a React Native view (e.g.,
<View>,<Text>) is nested inside an SVG<ForeignObject>, its own style properties like transform (scale, rotate, translate) and its layout position are ignored during rendering.This causes the nested view to be rendered incorrectly at the (0, 0) origin of the
<ForeignObject>without any of its applied transformations, making it impossible to style or position elements within the foreign object container.Solution
This PR fixes the issue by manually applying the child view's own position and transformation matrix to the drawing context (the
Canvason Android andCGContexton iOS) before the view is drawn.On iOS we also reset
hiddenproperty tofalsefor nested RN components insideForeignObjectwithinprepareForRecycle. This prevents views from being pooled in an invisible state and then disappearing when they are subsequently reused on different screens.With changes:

Before changes:

Test Plan
Run test case from issue: #2733
Compatibility
Checklist
README.md__tests__folder