Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FeComposite filter #2433

Merged
merged 23 commits into from
Oct 25, 2024
Merged

feat: FeComposite filter #2433

merged 23 commits into from
Oct 25, 2024

Conversation

jakex7
Copy link
Member

@jakex7 jakex7 commented Aug 30, 2024 •
edited
Loading

Summary

image

Test Plan

Examples app -> Filters -> FeComposite

Compatibility

OS Implemented
iOS ✅
macOS ❌*
Android ✅
Web ✅

* macOS isn't working as:

  • CGBitmapContextCreateImage always returns null
  • FeFlood isn't aligned properly (will be fixed in the following PR)

jakex7 added 23 commits August 28, 2024 15:27
@jakex7
feat: create FeComposite fabric
430175b
@jakex7
feat: implement ios composite filters
21ef4c0
@jakex7
feat: setup custom CoreImage Kernels using Metal
da1a6ff
@jakex7
feat: create composite Xor and Arithmetic kernels
73a46e0
@jakex7
feat: implement FeComposite on Android
a622190
@jakex7
fix: filter bitmap sizes
16d648e
@jakex7
docs: add examples for FeComposite
e27af89
@jakex7
fix: filters size in example app
708b545
@jakex7
feat: add CoreImage header to comply with macosx
8c905dc
@jakex7
chore: add paper view managers
cde51c6
@jakex7
fix: ios paper
56c1680
@jakex7
Merge branch 'main' into @jakex7/filtersFeComposite
ef68130
@jakex7
Merge branch 'main' into @jakex7/filtersFeComposite
d3e2510
@jakex7
Merge branch 'main' into @jakex7/filtersFeComposite
0c24561
@jakex7
Merge branch 'main' into @jakex7/filtersFeComposite
27e4d41
@jakex7
Merge branch 'main' into @jakex7/filtersFeComposite
0e37716
@jakex7
chore: generate metal
e356ddb
@jakex7
feat: compile separate metallib for every device types
c08a72f
@jakex7
feat: extract custom metal filter
349bf55
@jakex7
feat: update reference image
fc0387b
@jakex7
docs: add feCompostie to examples
b5abade
@jakex7
docs: revert unnecessary changes
892af70
@jakex7
Merge branch 'main' into @jakex7/filtersFeComposite
09e4420
@jakex7 jakex7 marked this pull request as ready for review October 25, 2024 09:17
@jakex7 jakex7 changed the title feat: introduce FeComposite filter feat: FeComposite filter Oct 25, 2024
@jakex7 jakex7 merged commit 4637dee into main Oct 25, 2024
11 of 12 checks passed
@jakex7 jakex7 deleted the @jakex7/filtersFeComposite branch October 25, 2024 09:18
@jakex7 jakex7 mentioned this pull request Oct 25, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jakex7