Correct return type of getTotalLength
in RNSVGRenderableManager
#2309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Opening this in draft as React Native 0.74.x comes with better support for Int32 & Float inside codegen (previously they would be converted to Double).
As I noticed you folks have this in your specs:
react-native-svg/src/fabric/NativeSvgRenderableModule.ts
Line 31 in a36a676
react-native-svg
will stop working with the next patch RN (most likely 0.74.4).To avoid this kind of problems in the future you folks can use
includesGeneratedCode
in the package.json:https://github.com/facebook/react-native/blame/75451d5b89d7f6c33688df23b57bea521374c2dc/packages/react-native-test-library/package.json#L44
Test Plan
This is sadly not easy to test as is. Once 0.74.4 will be out, I suspect
react-native-svg
will break. This PR will fix it and a patch release will be needed afterwards.