Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Xcode 12 compatibility #639

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Conversation

radko93
Copy link
Contributor

@radko93 radko93 commented Sep 17, 2020

Latest Xcode 12 fails to build while without a module to depend on React-Core directly hence this change is necessary for all native modules on iOS. This change requires React Native 0.60.2 or newer. For more details please check: facebook/react-native#29633 (comment)

@radko93 radko93 changed the title fix: autolinking when using Xcode 12 fix: Xcode 12 compatibility Sep 17, 2020
Copy link
Member

@WoLewicki WoLewicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WoLewicki WoLewicki merged commit 15557e2 into software-mansion:master Sep 17, 2020
@radko93 radko93 deleted the patch-2 branch September 17, 2020 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants