fix(Android, Stack v5): set needsCustomLayoutForChildren to true for StackHost#4200
Merged
Merged
Conversation
kligarski
requested review from
Copilot,
kkafar,
kmichalikk,
sgaczol and
t0maboro
Contributor
There was a problem hiding this comment.
Pull request overview
This PR mitigates a nondeterministic Android orientation-change sizing issue in Stack v5 by preventing Yoga from directly laying out StackHost children, ensuring child positioning is driven by native layout.
Changes:
- Override
needsCustomLayoutForChildren()inStackHostViewManagerto returntrue. - Add rationale in KDoc explaining why Yoga layout for children should be bypassed for
StackHost.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t0maboro
approved these changes
Jun 23, 2026
kligarski
force-pushed
the
@kligarski/stack-v5-android-fix-orientation
branch
from
d43a3f6 to
b6c024b
Compare
kligarski
force-pushed
the
@kligarski/stack-v5-android-fix-orientation
branch
from
b6c024b to
c0451de
Compare
sgaczol
pushed a commit
that referenced
this pull request
Jun 30, 2026
…for `StackHost` (#4200) ## Description Disables layout from Yoga for children of `StackHost`. Fixes a nondeterministic bug with incorrect screen size on orientation change. Closes software-mansion/react-native-screens-labs#1499. ### Details On orientation change, sometimes measure & layout from Yoga was applied with incorrect measurements. This is very likely connected to software-mansion/react-native-screens-labs#543, #3295 but I didn't investigate further why we receive the outdated measurements. In order to mitigate this, I decided to use similar strategy to `StackHeaderConfig`. By enabling `needsCustomLayoutForChildren` in `StackHostViewManager`, we will still receive `measure` with incorrect width & height from Yoga but `layout` won't be called. This way, incorrect measurements won't be applied and next native layout will remeasure & apply correct layout. Ultimately, we want the screen to be laid out fully by native layout, not by Yoga, so this is the desired behavior. If anything changes, `StackHost` receives new measurement from Yoga and will trigger native layout pass for `StackScreen`. ## Changes - set `needsCustomLayoutForChildren=true` in `StackHostViewManager` ## Before & after - visual documentation | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/737b9b88-4749-439a-a970-271edeff051a" /> | <video src="https://github.com/user-attachments/assets/7c14be70-4a00-42c0-aba2-aea8d793cb2f" /> | ## Test plan Run `test-stack-toolbar-menu-show-as-action`. Change orientation portrait -> landscape -> portrait multiple times. The content of the screen should be laid out correctly. ## Checklist - [x] Included code example that can be used to test this change. - [x] For visual changes, included screenshots / GIFs / recordings documenting the change. - [x] Ensured that CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Disables layout from Yoga for children of
StackHost. Fixes a nondeterministic bug with incorrect screen size on orientation change.Closes https://github.com/software-mansion/react-native-screens-labs/issues/1499.
Details
On orientation change, sometimes measure & layout from Yoga was applied with incorrect measurements. This is very likely connected to https://github.com/software-mansion/react-native-screens-labs/discussions/543, #3295 but I didn't investigate further why we receive the outdated measurements.
In order to mitigate this, I decided to use similar strategy to
StackHeaderConfig. By enablingneedsCustomLayoutForChildreninStackHostViewManager, we will still receivemeasurewith incorrect width & height from Yoga butlayoutwon't be called. This way, incorrect measurements won't be applied and next native layout will remeasure & apply correct layout. Ultimately, we want the screen to be laid out fully by native layout, not by Yoga, so this is the desired behavior. If anything changes,StackHostreceives new measurement from Yoga and will trigger native layout pass forStackScreen.Changes
needsCustomLayoutForChildren=trueinStackHostViewManagerBefore & after - visual documentation
before_orientation.mp4
after_orientation.mp4
Test plan
Run
test-stack-toolbar-menu-show-as-action. Change orientation portrait -> landscape -> portrait multiple times. The content of the screen should be laid out correctly.Checklist