feat(Android): Make commit hook condition for resetting screen size more general #3508
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichalikk
changed the title
kkafar
reviewed
Dec 23, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Hmm, this one is interesting and I'll revisit it.
I'm not sure whether we want to zero the shadow node state every single time when the screen dimensions change.
I'll look into it after new year. Thanks for the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/598
Description
This PR aims to generalize the condition in RNSScreenShadowNodeCommitHook to also include the screen resize, without orientation change. Let's discuss the change & decide how "general" should it be.
Even when triggering the mechanism on every screen resize, this shouldn't be a problem, since the change is still rare.
Changes
Modified the screen size reset condition in RNSScreenShadowNodeCommitHook
Test code and steps to reproduce
Use Test2933 & try split screen, floating window.