-
-
Notifications
You must be signed in to change notification settings - Fork 593
refactor(iOS): add type to header bar button items #3306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(iOS): add type to header bar button items #3306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @johankasperi
Thank you so much for another contribution!
I give 🟢 to the changes. We need, however, to revert few parts & we'll be good to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need changes to react-navigation submodule reverted here, before we merge.
apps/Example.tsx
Outdated
| title: 'Bar Button Items', | ||
| component: BarButtonItems, | ||
| type: 'playground', | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also needs to be reverted before we merge.
FabricExample/ios/Podfile.lock
Outdated
| RNGestureHandler: f1dd7f92a0faa2868a919ab53bb9d66eb4ebfcf5 | ||
| RNReanimated: aadd939e2bb8984700467ca876b422b0a07b75cb | ||
| RNScreens: 650bfd588793b73ed561b7870bf57d8e1e1dfd14 | ||
| RNScreens: 833237c48c756d40764540246a501b47dadb2cac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be reverted before we merge
228b793 to
89505f9
Compare
Thank you! Reverted the files you mentioned |
|
Hi @kkafar will this PR be merged today? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
Follow up PR after discussions and changes in react-navigation/react-navigation#12657
Changes
Following this comment react-navigation/react-navigation#12657 (comment) this PR adds a
type-property to all items in headerLeftBarButtonItems and headerRightBarButtonItems.Also updates the "Bar Button Items" to the latest API added in react-navigation/react-navigation#12657
Screenshots / GIFs
Here you can add screenshots / GIFs documenting your change.
You can add before / after section if you're changing some behavior.
Before
After
-->
Test code and steps to reproduce
Run the "Bar Button Items" example.
Checklist