Skip to content

Conversation

@johankasperi
Copy link
Contributor

Description

Follow up PR after discussions and changes in react-navigation/react-navigation#12657

Changes

Following this comment react-navigation/react-navigation#12657 (comment) this PR adds a type-property to all items in headerLeftBarButtonItems and headerRightBarButtonItems.

Also updates the "Bar Button Items" to the latest API added in react-navigation/react-navigation#12657

Screenshots / GIFs

Here you can add screenshots / GIFs documenting your change.

You can add before / after section if you're changing some behavior.

Before

After

-->

Test code and steps to reproduce

Run the "Bar Button Items" example.

Checklist

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @johankasperi
Thank you so much for another contribution!

I give 🟢 to the changes. We need, however, to revert few parts & we'll be good to merge.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need changes to react-navigation submodule reverted here, before we merge.

apps/Example.tsx Outdated
title: 'Bar Button Items',
component: BarButtonItems,
type: 'playground',
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be reverted before we merge.

RNGestureHandler: f1dd7f92a0faa2868a919ab53bb9d66eb4ebfcf5
RNReanimated: aadd939e2bb8984700467ca876b422b0a07b75cb
RNScreens: 650bfd588793b73ed561b7870bf57d8e1e1dfd14
RNScreens: 833237c48c756d40764540246a501b47dadb2cac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be reverted before we merge

@johankasperi johankasperi force-pushed the ios-bar-button-item-type branch from 228b793 to 89505f9 Compare October 20, 2025 10:11
@johankasperi
Copy link
Contributor Author

Hey @johankasperi Thank you so much for another contribution!

I give 🟢 to the changes. We need, however, to revert few parts & we'll be good to merge.

Thank you! Reverted the files you mentioned

@ajanuar
Copy link

ajanuar commented Oct 20, 2025

Hi @kkafar will this PR be merged today?

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kkafar kkafar merged commit c56d64b into software-mansion:main Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants