Skip to content

Conversation

@kligarski
Copy link
Contributor

@kligarski kligarski commented Sep 30, 2025

Description

Removes native code related to statusBarColor, statusBarTranslucent, navigationBarColor, navigationBarTranslucent, topInsetEnabled props.

Retained in JS for backward compatibility.

For reasons why those props are deprecated, please see #2638.

After this PR is merged, we should prepare corresponding PRs to react-navigation and react-navigation's docs. I created an issue to handle it: https://github.com/software-mansion/react-native-screens-labs/issues/487.

Closes #2632.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/485.

Changes

  • remove native code related to statusBarColor, statusBarTranslucent, navigationBarColor, navigationBarTranslucent, topInsetEnabled props
  • remove usage of those props in example apps (with appropriate comment to maintain full context of the tests)
  • remove edge-to-edge detection and react-native-is-edge-to-edge

Test code and steps to reproduce

Verify that app builds and runs.

Checklist

  • Ensured that CI passes

@kligarski kligarski changed the title feat!(Android, Stack v4): remove native code related to props deprecated by edge-to-edge enforcement feat!(Android, Stack v4): remove native code/deps related to props deprecated by edge-to-edge enforcement Sep 30, 2025
@kligarski kligarski marked this pull request as ready for review September 30, 2025 10:00
Copy link
Contributor

@kmichalikk kmichalikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

The only thing I'm not sure about is that we leave the props commented out in Tests. Do we really need it? Did the test rely on the prop - if so, maybe we should remove the test; if not - they don't add much value IMO. But that's just me, if we agreed to do it that way, then it's ok.

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job here. Only a single remark regarding GUIDE_FOR_LIBRARY_AUTHORS

@kligarski
Copy link
Contributor Author

The only thing I'm not sure about is that we leave the props commented out in Tests. Do we really need it? Did the test rely on the prop - if so, maybe we should remove the test; if not - they don't add much value IMO. But that's just me, if we agreed to do it that way, then it's ok.

After internal discussion with @kkafar, we decided that:

@kligarski kligarski requested review from kkafar and kmichalikk October 1, 2025 11:16
@kligarski kligarski merged commit 5168122 into main Oct 1, 2025
8 checks passed
@kligarski kligarski deleted the @kligarski/remove-deprecated-edge-to-edge-related-props branch October 1, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Your app uses deprecated APIs or parameters for edge-to-edge

4 participants