-
-
Notifications
You must be signed in to change notification settings - Fork 606
feat!(Android, Stack v4): remove native code/deps related to props deprecated by edge-to-edge enforcement #3264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(Android, Stack v4): remove native code/deps related to props deprecated by edge-to-edge enforcement #3264
Conversation
kmichalikk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
The only thing I'm not sure about is that we leave the props commented out in Tests. Do we really need it? Did the test rely on the prop - if so, maybe we should remove the test; if not - they don't add much value IMO. But that's just me, if we agreed to do it that way, then it's ok.
kkafar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job here. Only a single remark regarding GUIDE_FOR_LIBRARY_AUTHORS
After internal discussion with @kkafar, we decided that:
|
…set props are hard-coded to true
Description
Removes native code related to
statusBarColor,statusBarTranslucent,navigationBarColor,navigationBarTranslucent,topInsetEnabledprops.Retained in JS for backward compatibility.
For reasons why those props are deprecated, please see #2638.
After this PR is merged, we should prepare corresponding PRs to
react-navigationandreact-navigation's docs. I created an issue to handle it: https://github.com/software-mansion/react-native-screens-labs/issues/487.Closes #2632.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/485.
Changes
statusBarColor,statusBarTranslucent,navigationBarColor,navigationBarTranslucent,topInsetEnabledpropsedge-to-edgedetection andreact-native-is-edge-to-edgeTest code and steps to reproduce
Verify that app builds and runs.
Checklist