feat(iOS): Implement ScrollViewProviding protocol #3238
+79
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmichalikk
force-pushed
the
@kmichalikk/scroll-view-providing
branch
2 times, most recently
from
108ebe5 to
74644fe
Compare
kkafar
requested changes
Sep 24, 2025
kmichalikk
force-pushed
the
@kmichalikk/scroll-view-providing
branch
from
74644fe to
dd6f7cc
Compare
kmichalikk
changed the base branch from
main
to
@kmichalikk/scroll-edge-effects-test
kkafar
approved these changes
Sep 29, 2025
kmichalikk
force-pushed
the
@kmichalikk/scroll-view-providing
branch
from
4c3489c to
565df0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/456
Description
This PR implements ScrollViewProviding protocol as per internal discussion. The protocol enables us to be smarter about finding content ScrollView than simply descending into 0th child. A class that implements this protocol can decide how to continue the search. To complement the feature, ScrollViewFinder is updated with new method,
findContentScrollViewWithDelegatingToProviderthat takes advantage of the protocol.Note that we don't add the support for SplitView, because there should be no reason for it to be nested inside another container.
Changes
ScrollViewProvidingprotocol, with implementations forRNSScreenStack,BottomTabsHostComponentView. The implementations continue search directly from their currently selected screens. This has the desired side-effect of completing the search even if the screen is not yet mounted in host hierarchy.ScrollViewFinderto include a method that takes advantage of the new protocol, while leaving the simple versionTest code and steps to reproduce
Use Test3212; For now, nested containers may not behave as expected, because the new "smart" method is not called yet; things will change in the following PRs