feat(iOS, Stack): Add controller invalidating to new stack impl #3219
Conversation
t0maboro
force-pushed
the
@t0maboro/invalidate-new-stack
branch
from
2b07ead to
4d5bb10
Compare
| - (void)mountingTransactionWillMount:(const facebook::react::MountingTransaction &)transaction | ||
| withSurfaceTelemetry:(const facebook::react::SurfaceTelemetry &)surfaceTelemetry | ||
| { | ||
| for (const auto &mutation : transaction.getMutations()) { | ||
| if ([self shouldInvalidateOnMutation:mutation]) { | ||
| [RNSViewControllerInvalidator invalidateViewIfDetached:self forRegistry:_invalidatedComponentsRegistry]; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
First thing is: why do we have to scan whole list of mutations in every screen component? Why can't we just do it once per transaction in host component?
There was a problem hiding this comment.
flushInvalidViews is triggered when the component is moved out of the window. In such a scenario, the Host will keep all Screens in its registry - we don't know for how long (if the Screen cannot invalidate itself immediately on the mutation, it needs to mark that the mutation came and invalidate on willMoveToWindow:nil)
There was a problem hiding this comment.
🤔 I don't have good suggestion here unfortunately, but I dislike this solution for it's excessive (hopefully) transaction scanning. I'll try to come up with something better soon. We can discuss this on Monday.
I was testing it on
scenarios and all of them are determined by incoming |
Description
This change adds logic to detach the controller from its component when the component is destroyed. Unlike bottom tabs - where the Host handles detaching controllers from all its children - this approach delegates the responsibility to individual screens. This ensures a quicker response by detaching as soon as the screen is destroyed, rather than keeping views in the registry until the Host is unmounted.
Note: This is a temporary solution and will be replaced once a dedicated callback is available from Meta.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/127
Changes
RNSViewControllerInvalidatingprotocol for stackTest code and steps to reproduce
Verified with logs that the callback is triggered and the controller's reference is removed
Checklist