chore(Android): remove unnecesary check in Android build code #2608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
force-pushed
the
@kkafar/remove-unnecessary-check-in-android-build-code
branch
from
1132bf2 to
ed88dae
Compare
kkafar
deleted the
@kkafar/remove-unnecessary-check-in-android-build-code
branch
1 task
kligarski
added a commit
that referenced
this pull request
Feb 26, 2025
## Description Add fixes connected with changing RN to `react-native@0.77.1` before release. ## Changes - #2602 - #2603 - #2608 ## Test code and steps to reproduce Run example apps from the repo, run new app that uses RN 0.77.1 and this version of RNS. ## Checklist - [ ] Ensured that CI passes --------- Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since 0.72 RN uses AGP 7.4.x (see #2603) and we do not support any older versions.
Changes
Removed the check and merged both
buildFeaturesTest code and steps to reproduce
Passing Android build
Checklist