chore(README): Redact caution of migrating JS API of native stack #2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboba
changed the title
kkafar
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Hey, thanks for taking your time into improving the docs. I agree, that the wording there might be improved.
I have few remarks:
- The
react-native-screens/native-stackwill be removed in upcoming minor, not major version. - I don't like "[...] from now on" it is too vague. I want specific version of the library specified there.
- Maybe let's add some backticks to distinguish library names.
Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
kkafar
approved these changes
Nov 6, 2024
tboba
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because
react-native-screens/native-stackisn't moved to@react-navigation/native😄 I've changed the caution about moving the dependency into the correct one. Also, I've redacted the sentence, so for me it looks better now.Changes
@react-navigation/native-stackto@react-navigation/nativein README.