refact(Android): rename compareFrameSizes to checkFrameSizesEqualWithEps
#2217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
approved these changes
Jun 27, 2024
alduzy
pushed a commit
that referenced
this pull request
Jun 28, 2024
…ithEps` (#2217) ## Description As suggested by @alduzy, new the new function name should better convey its behaviour. Old came `compareFrameSizes` could suggest inequality. ## Changes Renamed `compareFrameSizes` to `checkFrameSizesEqualWithEps`. ## Test code and steps to reproduce Android should build on Fabric => CI ## Checklist - [ ] Ensured that CI passes
1 task
This was referenced Aug 23, 2024
This was referenced Aug 30, 2024
This was referenced Sep 24, 2024
ja1ns
pushed a commit
to WiseOwlTech/react-native-screens
that referenced
this pull request
Oct 9, 2024
…ithEps` (software-mansion#2217) ## Description As suggested by @alduzy, new the new function name should better convey its behaviour. Old came `compareFrameSizes` could suggest inequality. ## Changes Renamed `compareFrameSizes` to `checkFrameSizesEqualWithEps`. ## Test code and steps to reproduce Android should build on Fabric => CI ## Checklist - [ ] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested by @alduzy, new the new function name should better convey its behaviour.
Old came
compareFrameSizescould suggest inequality.Changes
Renamed
compareFrameSizestocheckFrameSizesEqualWithEps.Test code and steps to reproduce
Android should build on Fabric => CI
Checklist