Skip to content

feat: call onGestureCancel in modal too #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WoLewicki merged 2 commits into from
Jun 17, 2024
Merged

feat: call onGestureCancel in modal too #2184

WoLewicki merged 2 commits into from
Jun 17, 2024

Conversation

@WoLewicki
Copy link
Member

@WoLewicki WoLewicki commented Jun 14, 2024

Description

PR adding calling onGestureCancel when trying to dismiss a modal with gestureEnabled set to false.

Changes

Test code and steps to reproduce

Checklist

@kkafar kkafar self-requested a review June 17, 2024 08:21
kkafar
kkafar approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@kkafar kkafar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes are absolutely fine. Thanks 🙌🏻

@WoLewicki WoLewicki merged commit 1a54e22 into main Jun 17, 2024
@WoLewicki WoLewicki deleted the @wolewicki/gesture-cancel-in-modal branch June 17, 2024 10:59
@toomeem toomeem mentioned this pull request Jul 10, 2024
Merged
This was referenced Jul 17, 2024
Open
Open
Open
Open
Open
@asraful-cse asraful-cse mentioned this pull request Jul 21, 2024
Open
This was referenced Jul 22, 2024
Open
Open
Open
This was referenced Jul 24, 2024
Open
Open
This was referenced Jul 25, 2024
Open
Open
Open
Open
Open
Open
Open
@arenault-pass arenault-pass mentioned this pull request Jul 31, 2024
Closed
@shonore shonore mentioned this pull request Aug 1, 2024
Open
@prathik2401 prathik2401 mentioned this pull request Aug 1, 2024
Merged
This was referenced Aug 2, 2024
Open
Open
@kkafar kkafar mentioned this pull request Aug 6, 2024
Merged
8 tasks
@snyk-io snyk-io bot mentioned this pull request Aug 12, 2024
Open
This was referenced Aug 20, 2024
Open
Open
@WesleyR10 WesleyR10 mentioned this pull request Aug 21, 2024
Open
@shonore shonore mentioned this pull request Aug 22, 2024
Open
@Cabreira97 Cabreira97 mentioned this pull request Aug 23, 2024
Closed
This was referenced Aug 23, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Aug 30, 2024
Open
Open
Open
Open
Open
@undrthegraveyard undrthegraveyard mentioned this pull request Sep 4, 2024
Closed
@asraful-cse asraful-cse mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
@Ayush-Bulbule Ayush-Bulbule mentioned this pull request Oct 2, 2024
Merged
@tobistudio tobistudio mentioned this pull request Oct 3, 2024
Open
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
@WoLewicki @ja1ns
feat: call onGestureCancel in modal too (software-mansion#2184)
c018c42 
PR adding calling onGestureCancel when trying to dismiss a modal with gestureEnabled set to false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kkafar kkafar kkafar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WoLewicki @kkafar