Skip to content

Conversation

@tboba
Copy link
Contributor

@tboba tboba commented Apr 23, 2024

Description

This PR intents to fix error, during the install step on other React Native applications. That's because of the name of the step - it shouldn't be named as postinstall, as method named this way is triggered by yarn v4. This was not an issue before, as we used yarn v1.

Fixes #2108.

Changes

  • Changed postinstall name to prepare in package.json
  • Added yarn prepare command during the yarn release.

Checklist

  • Ensured that CI passes

Copy link
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's should be it.

@tboba tboba changed the title chore: Change postinstall step to prepare and run prepare on release in package.json fix: Change postinstall step to prepare and run prepare on release in package.json Apr 23, 2024
@tboba tboba merged commit 7aa5e7b into main Apr 23, 2024
@tboba tboba deleted the @tboba/fix-3.31.0-error branch April 23, 2024 13:37
ja1ns pushed a commit to WiseOwlTech/react-native-screens that referenced this pull request Oct 9, 2024
… package.json (software-mansion#2109)

## Description

This PR intents to fix error, during the install step on other React
Native applications. That's because of the name of the step - it
shouldn't be named as `postinstall`, as method named this way is
triggered by yarn v4. This was not an issue before, as we used yarn v1.

Fixes software-mansion#2108.

## Changes

- Changed `postinstall` name to `prepare` in package.json
- Added `yarn prepare` command during the `yarn release`.

## Checklist

- [ ] Ensured that CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[3.31.0] CI builds fails, command not found: bob

3 participants