Skip to content

fix(iOS): Don't include AVPlayerView in traverseForScrollView method #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2023
Merged

fix(iOS): Don't include AVPlayerView in traverseForScrollView method #1969

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ios/RNSScreen.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1423,6 +1423,15 @@ - (void)traverseForScrollView:(UIView *)view
// we don't want to send `scrollViewDidEndDecelerating` event to JS before the JS thread is ready
return;
}

if ([NSStringFromClass([view class]) isEqualToString:@"AVPlayerView"]) {
// Traversing through AVPlayerView is an uncommon edge case that causes the disappearing screen
// to an excessive traversal through all video player elements
// (e.g., for react-native-video, this includes all controls and additional video views).
// Thus, we want to avoid unnecessary traversals through these views.
return;
}

if ([view isKindOfClass:[UIScrollView class]] &&
([[(UIScrollView *)view delegate] respondsToSelector:@selector(scrollViewDidEndDecelerating:)])) {
[[(UIScrollView *)view delegate] scrollViewDidEndDecelerating:(id)view];
Expand Down