chore: consider new arch always enabled in react-native 0.82+ #8771
+12
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-new-arch-check
branch
from
23d41cb to
8ac3926
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/fix-new-arch-check
branch
from
8ac3926 to
3c6d209
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting from react-native 0.82, users can no longer disable the new architecture in their projects, and because of that, the
newArchEnabledproperty ingradle.propertiesis no longer required. The problem is that we still check specifically forrootProject.hasProperty("newArchEnabled")inandroid/build.gradle.Test plan
In a react-native project running 0.82+, remove the
newArchEnabledproperty fromgradle.propertiesand build