CSS SVGPath interpolation #8710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatiPl01
reviewed
Dec 22, 2025
Member
MatiPl01
left a comment
MatiPl01
left a comment
There was a problem hiding this comment.
Looks great! Most of the comments I left are minor suggestions and only a few of them are more important (like path validation ones).
apps/common-app/src/apps/css/examples/animations/screens/animatedProperties/svg/Path.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/apps/css/examples/animations/screens/animatedProperties/svg/Path.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/apps/css/examples/animations/screens/animatedProperties/svg/Path.tsx
Outdated
Show resolved
Hide resolved
apps/common-app/src/apps/css/examples/animations/screens/animatedProperties/svg/Path.tsx
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGPath.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGPath.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGPath.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGPath.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGPath.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/CSS/svg/values/SVGPath.cpp
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8709 has to be merged before this PR.
Summary
PR add SVG Path CSS Property which enables animation of SVG Paths. It uses parser and normalizer created in #8709.
Test plan
You can play with prepared examples:
Run fabric-example -> CSS -> Animated Properties -> SVG Properties -> Path