[LA] Update window update check #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Oct 22, 2024
tomekzaw
reviewed
Oct 22, 2024
...ges/react-native-reanimated/Common/cpp/reanimated/LayoutAnimations/LayoutAnimationsProxy.cpp
Outdated
Show resolved
Hide resolved
bartlomiejbloniarz
deleted the
@bartlomiejbloniarz/fix-la-window-dimensions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way we keep track of the window dimensions in Layout Animations on the New Arch. The previous version didn't work on Android in release mode. This new approach is possible because we moved the initialization of layout animations to the commit hook in #6586.
Test plan
Check if Layout Animations dependent on
windowWidth(e.g. SlideInLeft) work properly.