Convert double-quoted includes to angle includes #6537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plz fix import orders for CI 🙏 |
tomekzaw
changed the title
tjzel
approved these changes
Sep 24, 2024
packages/react-native-reanimated/Common/cpp/reanimated/Fabric/ReanimatedCommitShadowNode.h
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/cpp/reanimated/NativeProxy.h
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/android/src/main/cpp/worklets/CMakeLists.txt
Show resolved
Hide resolved
…odules/NativeReanimatedModule.cpp Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 18, 2024
## Summary PR adding back headers removed in #6537. For some reason, locally they are not needed, probably to some different setup or having the libraries set globally somewhere, but it caused failures in Expensify: https://github.com/Expensify/App/actions/runs/11857735322/job/33046828856. They should be included since methods from them are used. ## Test plan Not really, just run CIs probably.
tjzel
pushed a commit
that referenced
this pull request
Nov 20, 2024
## Summary PR adding back headers removed in #6537. For some reason, locally they are not needed, probably to some different setup or having the libraries set globally somewhere, but it caused failures in Expensify: https://github.com/Expensify/App/actions/runs/11857735322/job/33046828856. They should be included since methods from them are used. ## Test plan Not really, just run CIs probably.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
#include "someheader.hto#include <reanimated/path/to/someheader.h>CMakeLists.txtandRNReanimated.podspec) to change header pathsCommon/cpp/reanimatedorCommon/cpp/worklets, as well as one forapple/reanimated, so that header paths are correct (otherwise CocoaPods flattens nested directories)yarn lint:{android,apple,common})Next PRs:
#import <RNReanimated/*.h>to#import <reanimated/**/*.h>inapple/directoryreanimatedC++ namespace toswmansion::reanimatedandswmansion::workletsTest plan