Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable strict mode by default, remove fatal log, add missing web check #6477

Merged
merged 7 commits into from
Sep 9, 2024
Merged

chore: Enable strict mode by default, remove fatal log, add missing web check #6477

merged 7 commits into from
Sep 9, 2024

Conversation

MatiPl01
Copy link
Member

@MatiPl01 MatiPl01 commented Sep 3, 2024 •
edited
Loading

Summary

This PR is just a set of logger implementation improvements.

  • fixes crash on web caused by missing check before the executeOnUIRuntimeSync call (which doesn't exist on web),
  • enables strict mode by default,
  • removes fatal log level as it is not used anywhere.

@MatiPl01 MatiPl01 self-assigned this Sep 3, 2024
@MatiPl01 MatiPl01 marked this pull request as ready for review September 3, 2024 14:00
@MatiPl01 MatiPl01 requested a review from tjzel September 3, 2024 14:03
@MatiPl01 MatiPl01 force-pushed the @matipl01/logger-config-improvements branch from 4328e67 to ec4f928 Compare September 3, 2024 14:03
@MatiPl01 MatiPl01 mentioned this pull request Sep 3, 2024
Merged
tjzel
tjzel approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

packages/react-native-reanimated/src/mutables.ts Outdated Show resolved Hide resolved
packages/react-native-reanimated/src/mutables.ts Outdated Show resolved Hide resolved
MatiPl01 and others added 4 commits September 9, 2024 12:29
@MatiPl01 @tjzel
Update packages/react-native-reanimated/src/mutables.ts
62da52e 
Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
@MatiPl01 @tjzel
Update packages/react-native-reanimated/src/mutables.ts
9bfbf53 
Co-authored-by: Tomasz Żelawski <40713406+tjzel@users.noreply.github.com>
@MatiPl01
Merge branch 'main' into @matipl01/logger-config-improvements
2120e7b
@MatiPl01
Fix linting issue
501c892
@MatiPl01 MatiPl01 added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit d186f86 Sep 9, 2024
8 checks passed
@MatiPl01 MatiPl01 deleted the @matipl01/logger-config-improvements branch September 9, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjzel tjzel tjzel approved these changes

@kacperkapusciak kacperkapusciak Awaiting requested review from kacperkapusciak

Assignees

@MatiPl01 MatiPl01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatiPl01 @tjzel