Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RN pager view patch file #6397

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

szydlovsky
Copy link
Contributor

Summary

Our patch to react-native-pager-view for RN 0.75-rc.6 works, but seems like it isn't the best way to do that, as stated here. In short, removing the override keyword will cause tab bar navigation crashes. Instead, I adjusted the functions' signature, so that they actually override something.

Test plan

Try building android examples

@szydlovsky szydlovsky requested a review from tomekzaw August 9, 2024 10:55
@Romick2005
Copy link

It is better to go with this fix.

@szydlovsky
Copy link
Contributor Author

szydlovsky commented Aug 19, 2024

@Romick2005 yeah, I use exactly that fix (brought back override, removed nullability of child arguments)

@szydlovsky szydlovsky added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 467289a Aug 19, 2024
7 checks passed
@szydlovsky szydlovsky deleted the @szydlovsky/update-rn-pagerview-patch branch August 19, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants