refactor: Split Java and ObjC code into Reanimated and Worklets dirs #6366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the base branch from
main
to
@tjzel/worklets/remove-worklet-dependency
tjzel
force-pushed
the
@tjzel/worklets/remove-worklet-dependency
branch
from
68a6688 to
de9b068
Compare
tjzel
force-pushed
the
@tjzel/worklets/dirs-for-native-code
branch
from
5289682 to
95b2238
Compare
Base automatically changed from
@tjzel/worklets/remove-worklet-dependency
to
main
August 8, 2024 14:14
tjzel
force-pushed
the
@tjzel/worklets/dirs-for-native-code
branch
from
f53cd68 to
567ce36
Compare
tomekzaw
requested changes
Aug 9, 2024
packages/react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Aug 9, 2024
packages/react-native-reanimated/android/src/main/cpp/reanimated/CMakeLists.txt
Outdated
Show resolved
Hide resolved
piaskowyk
approved these changes
Aug 12, 2024
tomekzaw
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the continuation of the code split made in common C++ layer. All of the files currently go to
reanimateddirectory, moving some of them toworkletswill happen in follow-up PRs.Requires #6357.
Test plan