Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in our example app #5783

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Fix example in our example app #5783

merged 2 commits into from
Mar 18, 2024

Conversation

Latropos
Copy link
Contributor

@Latropos Latropos commented Mar 12, 2024

Summary

The goal of this PR is to fix two of our examples - Matrix & Pendulum

Pendulum

Allow to pass fractional numbers to input fields. Previously we were filtering out everything except for digits, but we should allow users to pass dot as well.

Matrix

Make the example more descriptive, add additional information. Use the same styling as for pednulum.

BEFOREAFTER

image

image

Test plan

@Latropos Latropos requested a review from tjzel March 12, 2024 08:48
@Latropos Latropos marked this pull request as ready for review March 12, 2024 11:49
@Latropos Latropos added this pull request to the merge queue Mar 18, 2024
Merged via the queue into main with commit 469d708 Mar 18, 2024
6 checks passed
@Latropos Latropos deleted the acynk/example-fixes branch March 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants