-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FPSCounter #5770
FPSCounter #5770
Conversation
|
Hot-reloads break this feature. Looks like both the old |
This component does not have the earlier mention hot-reload issues when running as a component imported from |
Do we push this component just as an example for now, or should we make a standalone component out of it? |
Added performance monitor example. Removed PR specific mess from EmptyExample and Bokeh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@latekvo The PR looks great! There are some smaller quality-of-life things to add. It would also be great if you featured a Summary
and a Test plan
for the PR. If it comes to the summary, just a few sentences describing the feature (and possibly its limitations if there are any), some video showcasing it would also be great. Test plan usually comes down to pointing to a specific example in our app - but if you have any extra code that the feature can be tested on, make sure to include it!
Thank you for the review @szydlovsky :) |
This comment was marked as outdated.
This comment was marked as outdated.
Screen.Recording.2024-03-25.at.15.05.35.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
Summary
This PR adds a new Reanimated component which displays current fps for both JS and UI threads.
Test plan
Open Reanimated Example on your android/ios emulator and go into the
Performance Monitor Example