fix(android,animated-sensor): Fix HMR for Animated Sensor #5646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While playing with
useAnimatedSensor(SensorType.GYROSCOPE)
I was really annoyed that every time my app hot reloaded I got error like this:Cannot assign to read-only property 'sensor'
orCannot assign to read-only property 'unregister'
.There seems to be some issue that properties inside "ref.current" becomes read-only so I added code that will replace whole
ref.current
instead of replacing properties one by one at begging ofuseEffect
. This seems to solve the issue.Also it seems that this is Android only issue. I did not encounter that on iOS.
Here are screenshots of errors https://photos.google.com/share/AF1QipM1cQFJI67AGuTyth9CY3EGM6Ipy80Jp_uSivmoHf2dTU3aRDaXSLk2TliVKO2hNg?key=bVVNWE1SRHBrcFBreW5HZFpyWGlOcGxkelVKSW9n
Test plan
There is simple code that will throw errors on Android on every hot reload without fix from this PR. You can change that
console.log
beforeuseFrameCallback
to trigger HMR.