Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for error messages #505

Merged
merged 32 commits into from
Dec 17, 2019
Merged

Improvement for error messages #505

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
5f32883
add validation in native and JS for add and always
jkadamczyk Apr 18, 2019
ea2978e
add util wrapping get metods of ReadableMap with try catch block
jkadamczyk Apr 18, 2019
fbce9a8
add to more nodes
jkadamczyk Apr 18, 2019
9f998f4
change to invariant
jkadamczyk Apr 18, 2019
8729228
add invariant error messages for clocks
jkadamczyk Apr 19, 2019
515abae
remove typeof from animated clock
jkadamczyk Apr 19, 2019
d015ef7
add toString method to nodes
jkadamczyk Apr 19, 2019
9f08d12
add more generic names to errorMessages
jkadamczyk Apr 19, 2019
a1d5162
fix error messages to be closer to reality
jkadamczyk Apr 19, 2019
50a91de
delete future proofed code not being used
jkadamczyk Apr 19, 2019
52bfda7
make error reporting somewhat consistent between JS and Java
jkadamczyk Apr 19, 2019
487fe43
Add Type checking for map elements on iOS
jkadamczyk Apr 23, 2019
73f3b16
add checks to Java Bezier and clock nodes
jkadamczyk Apr 23, 2019
96beef2
add Objective-C Macro for nil check on node IDs
jkadamczyk Apr 25, 2019
4921193
Revert pbxproj known region addition
jkadamczyk Apr 25, 2019
144ac6d
Merge branch 'master' into improvement-better-error-messages
Apr 25, 2019
8f7fd3a
fix imports on android
jkadamczyk Apr 25, 2019
1754824
fix styling issues in iOS code
jkadamczyk Apr 25, 2019
a57b735
add more type checks for other nodes
jkadamczyk Apr 26, 2019
780dd71
add iOS and Java type safety
jkadamczyk Apr 26, 2019
34e7cde
add MapUtils to cond node
jkadamczyk Apr 26, 2019
8352a5e
unify type checking in js
jkadamczyk Apr 26, 2019
3d80b75
Restore missing line
osdnk Apr 26, 2019
430c972
Get rid of useless cond
osdnk May 27, 2019
950a90f
move before calling super to avoid constructing
jkadamczyk May 28, 2019
7f2d9bd
remove passing node ID on both android and iOS
jkadamczyk Jun 12, 2019
8cf1284
Merge branch 'master' into improvement-better-error-messages
jakub-gonet Dec 5, 2019
ac5c7b2
Remove duplicated import
jakub-gonet Dec 5, 2019
7291d00
Add error messages to AnimatedCallFunc
jakub-gonet Dec 5, 2019
2f83210
Add error messages to AnimatedFunction
jakub-gonet Dec 5, 2019
9c0433b
Update signature of REA_LOG_ERROR_IF_NIL
jakub-gonet Dec 13, 2019
f2b30ea
Add node id check to callFuncNode
jakub-gonet Dec 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update signature of REA_LOG_ERROR_IF_NIL 
We don't use nodeID
  • Loading branch information
@jakub-gonet
jakub-gonet committed Dec 13, 2019
commit 9c0433ba09922c364899819d60a3b1d2270f03c3
4 changes: 2 additions & 2 deletions ios/REAUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#import <Foundation/Foundation.h>

#define REA_LOG_ERROR_IF_NIL(value, errorMsg, nodeID) ({\
if (value == nil) RCTLogError(errorMsg, nodeID);\
#define REA_LOG_ERROR_IF_NIL(value, errorMsg) ({\
if (value == nil) RCTLogError(errorMsg);\
})