Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSLogger class and duplicate SET tags #4675

Merged
merged 19 commits into from
Jul 11, 2023
Merged

Add JSLogger class and duplicate SET tags #4675

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
d5cfcff
v 1.0
tjzel Jul 5, 2023
24a800e
if debug
tjzel Jul 5, 2023
04cae13
improve example
tjzel Jul 5, 2023
a8af71c
missing DEBUG
tjzel Jul 5, 2023
45713f9
won't work without boost
tjzel Jul 5, 2023
eaabf7e
android has issues
tjzel Jul 6, 2023
25e64a8
android works
tjzel Jul 6, 2023
a615676
better exampol
tjzel Jul 6, 2023
86c9c4c
add missing default (?)
tjzel Jul 6, 2023
58cd990
Merge branch 'main' into @tjzel/SET/find-duplicate-tags
tjzel Jul 6, 2023
dea6399
review changes
tjzel Jul 7, 2023
c86c8d6
typo
tjzel Jul 7, 2023
724a4a3
review changes
tjzel Jul 7, 2023
b052e99
Merge branch 'main' into @tjzel/SET/find-duplicate-tags
tjzel Jul 7, 2023
ec84514
move hasDuplicateSharedTag to checkDuplicateSharedTag
tjzel Jul 7, 2023
cc6d913
fix return value
tjzel Jul 7, 2023
bab30e5
remove return
tjzel Jul 11, 2023
5f8065e
review changes w/o assert
tjzel Jul 11, 2023
c2b1f5c
add assert
tjzel Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
missing DEBUG
  • Loading branch information
@tjzel
tjzel committed Jul 5, 2023
commit a8af71c3e6b7abf4cd1b38167aaa58841b47af79
2 changes: 2 additions & 0 deletions Common/cpp/LayoutAnimations/LayoutAnimationsManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,10 @@ class LayoutAnimationsManager {
bool cancelled /* = true */,
bool removeView /* = true */);
int findPrecedingViewTagForTransition(int tag);
#ifdef DEBUG
bool hasDuplicateSharedTag(int viewTag, int screenTag);
tjzel marked this conversation as resolved.
Show resolved Hide resolved
void initializeJSLogger(const std::shared_ptr<JSLogger> &jsLogger);
tjzel marked this conversation as resolved.
Show resolved Hide resolved
#endif
tjzel marked this conversation as resolved.
Show resolved Hide resolved

private:
std::unordered_map<int, std::shared_ptr<Shareable>> &getConfigsForType(
Expand Down