Replace console.error with throw new Error #4452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
approved these changes
May 15, 2023
|
I've just changed |
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR changes the behavior of the app when version mismatch is detected. Previously, we called `console.error` in such case, but the app still continued to execute. This PR replaces `console.error` with `throw new Error` which stops the execution and shows full-screen LogBox. | Before | After | |:-:|:-:| | <img width="459" alt="before" src="https://github.com/software-mansion/react-native-reanimated/assets/20516055/4b58c8f8-350a-4d17-8c3a-51a9a3cf1fc9"> | <img width="459" alt="after" src="https://github.com/software-mansion/react-native-reanimated/assets/20516055/53cd425f-4da1-4ff4-86c8-776fdcbfe4a0"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the behavior of the app when version mismatch is detected. Previously, we called
console.errorin such case, but the app still continued to execute. This PR replacesconsole.errorwiththrow new Errorwhich stops the execution and shows full-screen LogBox.