Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing dependency on React-hermes on older RN versions #4044

Merged
merged 7 commits into from
Feb 22, 2023
Merged

Fix missing dependency on React-hermes on older RN versions #4044

merged 7 commits into from
Feb 22, 2023

Conversation

jwajgelt
Copy link
Contributor

Summary

Test plan

@jwajgelt jwajgelt requested a review from tomekzaw February 10, 2023 12:43
tomekzaw
tomekzaw reviewed Feb 10, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
tomekzaw
tomekzaw reviewed Feb 20, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
@tomekzaw tomekzaw changed the title Fix missing dependency on React-Hermes on older RN versions Fix missing dependency on React-hermes on older RN versions Feb 20, 2023
piaskowyk
piaskowyk approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me 👍 But I ask you to add in PR description some information how you tested if it works and which RN versions did you use for testing.

tomekzaw
tomekzaw reviewed Feb 21, 2023
View reviewed changes
RNReanimated.podspec Outdated Show resolved Hide resolved
@jwajgelt
Copy link
Contributor Author

Good for me 👍 But I ask you to add in PR description some information how you tested if it works and which RN versions did you use for testing.

I just run it through @tomekzaw's e2e test suite, on the whole version list.
I generally assume that if it builds and runs, there shouldn't be any changes in behaviour, but the tests pass locally for me as well.

tomekzaw
tomekzaw approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwajgelt for this PR! 👏

@jwajgelt jwajgelt added this pull request to the merge queue Feb 22, 2023
Merged via the queue into main with commit 07fdacb Feb 22, 2023
@jwajgelt jwajgelt deleted the @jwajgelt/fix-hermes-dependency branch February 22, 2023 14:54
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@jwajgelt @fluiddot
Fix missing dependency on React-hermes on older RN versions (softwa…
e2bd961 
…re-mansion#4044)

<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

<!-- Explain the motivation for this PR. Include "Fixes #<number>" if
applicable. -->

## Test plan

<!-- Provide a minimal but complete code snippet that can be used to
test out this change along with instructions how to run it and a
description of the expected behavior. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jwajgelt @tomekzaw @piaskowyk