Auto add proguard config #3494
Merged
Auto add proguard config #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piaskowyk looks like this failed on some non-linked code. |
|
@piaskowyk could you help with running the workflows again? |
tomekzaw
approved these changes
Jan 3, 2023
tomekzaw
approved these changes
Feb 15, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description <!-- Description and motivation for this PR. Inlude Fixes #<number> if this is fixing some issue. Fixes # . --> This will automatically configure proguard rules. Preventing crahes for people who miss out on adding these steps, or use expo with proguard. ## Changes <!-- Please describe things you've changed here, make a **high level** overview, if change is simple you can omit this section. For example: - Added `foo` method which add bouncing animation - Updated `about.md` docs - Added caching in CI builds --> Added proguard rules config, and enabled consumerProguardFiles in build.gradle. ## Test code and steps to reproduce All tests pass. ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [x] Updated documentation - [x] Ensured that CI passes --------- Co-authored-by: Krzysztof Piaskowy <krzychu2956@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will automatically configure proguard rules. Preventing crahes for people who miss out on adding these steps, or use expo with proguard.
Changes
Added proguard rules config, and enabled consumerProguardFiles in build.gradle.
Test code and steps to reproduce
All tests pass.
Checklist