Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only inject global.performance.now if not already defined #2771

Merged
merged 1 commit into from
Dec 22, 2021

Conversation

mrousavy
Copy link
Contributor

Alternative solution to #2761, related: #2760

@mrousavy
Copy link
Contributor Author

cc @michaelknoch

@mrousavy
Copy link
Contributor Author

sorry for not dropping a detailed description - but basically with this approach the outer if isn't too confusing, and it also provides the possibility of having global.performance natively injected in the future (assuming that's where RN is heading, with JSI) cc @piaskowyk

Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable changes 🚀

@piaskowyk piaskowyk merged commit 9c441ac into software-mansion:main Dec 22, 2021
@nandorojo
Copy link
Contributor

This fixed remote debugging for me, thanks!

@daxaxelrod
Copy link

Holy macaroni salad thanks a ton. Redux for flipper still needs work and it's awesome to get react-native-debugger back

aeddi pushed a commit to aeddi/react-native-reanimated that referenced this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants