Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors #2698

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Fix lint errors #2698

merged 3 commits into from
Dec 8, 2021

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Dec 7, 2021

Description

Changes

Test code and steps to reproduce

Checklist

  • Included code example that can be used to test this change
  • Updated TS types
  • Added TS types tests
  • Added unit / integration tests
  • Updated documentation
  • Ensured that CI passes

@tomekzaw tomekzaw requested a review from piaskowyk December 7, 2021 19:39
Comment on lines +493 to +495
export type EntryExitAnimationFunction =
| ((targetValues: EntryAnimationsValues) => LayoutAnimation)
| ((targetValues: ExitAnimationsValues) => LayoutAnimation);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the best possible solution, but hey, it works.

Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit 💪

@tomekzaw tomekzaw merged commit de26314 into master Dec 8, 2021
@tomekzaw tomekzaw deleted the @tomekzaw/fix-lint-errors branch December 8, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants