TypeScript for Layout Animations #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
commented
Jun 17, 2021
| @@ -179,7 +179,7 @@ export function withStartValue(startValue, animation) { | |||
| }); | |||
| } | |||
|
|
|||
| export function withTiming(toValue, userConfig, callback) { | |||
| export function withTiming(toValue: any, userConfig: any, callback?: any) { | |||
There was a problem hiding this comment.
It is just a temporary solution. We will add types for animation in the next PR.
piaskowyk
changed the title
jakub-gonet
reviewed
Jun 17, 2021
Comment on lines
+4
to
+5
| declare namespace NodeJS { | ||
| interface Global { |
There was a problem hiding this comment.
Why this is wrapped in Nodejs namespace?
There was a problem hiding this comment.
I found information that
namespace NodeJS is required for the definition of properties in the global object. But correct me please if I am wrong.
src/reanimated2/layoutReanimation/animationBuilder/BaseAnimationBuilder.ts
Outdated
Show resolved
Hide resolved
src/reanimated2/layoutReanimation/animationBuilder/commonTypes.ts
Outdated
Show resolved
Hide resolved
src/reanimated2/layoutReanimation/animationBuilder/commonTypes.ts
Outdated
Show resolved
Hide resolved
Szymon20000
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added types for LayoutAnimations
Checklist