Support RN64 for android #1667
Merged
Support RN64 for android #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yacubane
approved these changes
Jan 29, 2021
|
Good job! |
BluValor
approved these changes
Jan 29, 2021
Szymon20000
suggested changes
Jan 29, 2021
|
Have you checked if RN 63 and 62 are still working with this pr? |
|
Yes, I tested this PR with RN 62, 63, 64, and works without any problems. |
jakub-gonet
reviewed
Feb 1, 2021
|
|
||
| # PART II (clean) | ||
| for index in {0..2} |
There was a problem hiding this comment.
length="${#versions[@]}"
for ((i=0; i < $length; i++ )); do echo $i; doneI think explicitly setting length and using for loop is more readable.
jakubowiczish
approved these changes
Feb 1, 2021
Szymon20000
suggested changes
Feb 3, 2021
Szymon20000
approved these changes
Feb 3, 2021
|
Any ETA on a new release with support for RN64? |
|
next few days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for React Native v0.64.0.-rc.2 for android devices. This PR is based on: https://github.com/osdnk/react-native-reanimated/tree/64 - thanks @osdnk 🙌
I compiled with
android-ndk-r19cFixes: #1680