Refactor of global values #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-gonet
reviewed
Nov 27, 2020
added 2 commits
November 27, 2020 14:34
karol-bisztyga
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
Please wait for @jakub-gonet to approve, for me it looks alright
jakub-gonet
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Using many global values is not a good practise. Global values can be changed everywhere and it makes potential debugging difficult. Local scope is also better for memory usage.
Changes
_updatePropsJS()from global scope and moved it to local scope._globalSetter()na_setGlobalConsole()because this setter was used only to addconsoleto global object, code here. This blocks the possibility to create global values in runtime, we have control on content of global scope now.